Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17763] Update LimitItemDeletion feature flag #13184

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17763

📔 Objective

Fix feature flag casing and move to appropriate feature flag grouping

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details07132270-00ed-4b5e-8d41-0d3586a7973e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.50%. Comparing base (82f416c) to head (f7eb72a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13184   +/-   ##
=======================================
  Coverage   35.49%   35.50%           
=======================================
  Files        3007     3007           
  Lines       90887    90888    +1     
  Branches    16906    16907    +1     
=======================================
+ Hits        32260    32267    +7     
+ Misses      56125    56119    -6     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentsalucci vincentsalucci merged commit 22edfd4 into main Jan 31, 2025
85 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-17763/update-feature-flag branch January 31, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants