Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17819] Replicate ReactiveForms and bit-* component changes to Blocked Domains #13180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blackwood
Copy link

@blackwood blackwood commented Jan 31, 2025

Replicate ReactiveForms and bit-* component changes to Blocked Domains from Excluded Domains update PM-13808.

๐ŸŽŸ๏ธ Tracking

PM-17819

๐Ÿ“” Objective

  • Field styles use <bit-form-field> styles
  • Field extends width of the card
  • Added domains are aligned vertically with the remove icon button

๐Ÿ“ธ Screenshots

After:

Screenshot 2025-01-31 at 10 16 08โ€ฏAM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@blackwood blackwood requested a review from a team as a code owner January 31, 2025 15:17
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 03864db3-c5d2-41a7-9ad3-f1ea2ee0cb25

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.50%. Comparing base (d7c46bb) to head (20a65d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tofill/popup/settings/blocked-domains.component.ts 0.00% 7 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13180   +/-   ##
=======================================
  Coverage   35.50%   35.50%           
=======================================
  Files        3008     3008           
  Lines       90918    90922    +4     
  Branches    16911    16912    +1     
=======================================
+ Hits        32279    32286    +7     
+ Misses      56137    56134    -3     
  Partials     2502     2502           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@blackwood blackwood added the needs-qa Marks a PR as requiring QA approval label Jan 31, 2025
โ€ฆcked Domains from Excluded Domains update [PM-13808].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant