[PM-17745] Catch network errors in new device notification guard

[shane-melton]

🎟️ Tracking

PM-17745

📔 Objective

Add try/catch to the NewDeviceVerificationNoticeGuard to prevent locking users out of the client when there is a network error or is otherwise unable to retrieve the user profile to determine eligibility for showing the new device notification.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – fee13d62-668c-4390-97a5-eec104952926

Great job, no security vulnerabilities found in this Pull Request

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (cbba1a6) to head (1bfc1ad).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13161   +/-   ##
=======================================
  Coverage   35.48%   35.49%           
=======================================
  Files        3007     3007           
  Lines       90872    90874    +2     
  Branches    16904    16904           
=======================================
+ Hits        32250    32259    +9     
+ Misses      56120    56113    -7     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.