Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14421] Access Intelligence: Introduce At-risk Passwords Page #13044

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Jan 24, 2025

🎟️ Tracking

PM-14421

📔 Objective

Introduce the At-risk Passwords page for Risk Insights.

📸 Screenshots

Opening At-Risk Passwords Page

Opening At-Risk Passwords Page Autofill Setting Callout Behavior
Screen.Recording.2025-01-23.at.4.18.19.PM.mov
Screen.Recording.2025-01-23.at.5.06.20.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Logo
Checkmarx One – Scan Summary & Details9600c764-4f1f-4c81-bfa2-aa37585963a2

New Issues (8)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 58
detailsMethod AtRiskPasswordsComponent at line 58 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user ...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 81
detailsMethod Lambda at line 81 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user information outsid...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 96
detailsMethod Lambda at line 96 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user information outsid...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 58
detailsMethod AtRiskPasswordsComponent at line 58 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user ...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 81
detailsMethod Lambda at line 81 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user information outsid...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 96
detailsMethod Lambda at line 96 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user information outsid...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 58
detailsMethod AtRiskPasswordsComponent at line 58 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user ...
Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts: 81
detailsMethod Lambda at line 81 of /apps/browser/src/vault/popup/components/at-risk-passwords/at-risk-passwords.component.ts sends user information outsid...
Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant