[PM-12045] search service activeuserstate #13035
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13035 +/- ##
==========================================
+ Coverage 35.10% 35.19% +0.08%
==========================================
Files 3000 2998 -2
Lines 91320 91107 -213
Branches 17094 17046 -48
==========================================
+ Hits 32062 32069 +7
+ Misses 56754 56533 -221
- Partials 2504 2505 +1 ☔ View full report in Codecov by Sentry. |
| private isSearching$ = combineLatest([ | ||
| this.searchControl.valueChanges, | ||
| this.accountService.activeAccount$.pipe( | ||
| map((a) => a?.id), |
There was a problem hiding this comment.
Please use the helper rjxs operators for this: https://github.com/bitwarden/clients/blob/main/libs/common/src/auth/services/account.service.ts#L51-L67.
I suggest that you use getUserId which requires a UserId, then you don't have to filter out nulls in the next line.
There was a problem hiding this comment.
oh did not know this was there. This is awesome. thanks!
There was a problem hiding this comment.
This file is unused and can be deleted. It looks like it was missed in a previous feature flag cleanup.
There was a problem hiding this comment.
This file is unused and can be deleted. It looks like it was missed in a previous feature flag cleanup.
🎟️ Tracking
PM-12045
📔 Objective
Remove ActiveUserState from search service
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes