Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move max-old-space-size option so it's in all builds #13033

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

justindbaur
Copy link
Member

🎟️ Tracking

📔 Objective

Move the NODE_OPTIONS=\"--max-old-space-size=8192\" that we increased #12483 from just being for production builds in browser to being for the builds we expect developers to run as well. All other clients do it for the dev builds scripts already.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested review from a team and coroiu January 23, 2025 17:00
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details9f7dea10-ee74-47f1-bceb-05fffa5c1b08

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.11%. Comparing base (2d488a8) to head (2852568).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13033   +/-   ##
=======================================
  Coverage   35.10%   35.11%           
=======================================
  Files        2990     2990           
  Lines       91097    91097           
  Branches    17058    17058           
=======================================
+ Hits        31984    31991    +7     
+ Misses      56615    56608    -7     
  Partials     2498     2498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rip everyone with 16GB RAM

@justindbaur justindbaur merged commit 5f57aae into main Jan 24, 2025
35 of 36 checks passed
@justindbaur justindbaur deleted the move-max-old-space-browser branch January 24, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants