Simplelogin alias generation only generate random words instead the domain name #13024
+147
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
albertboyd5
changed the title
1 task
This comment was marked as resolved.
This comment was marked as resolved.
audreyality
requested changes
Jan 23, 2025
libs/tools/generator/components/src/username-generator.component.ts
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
audreyality
reviewed
Jan 29, 2025
...c/vault/popup/components/vault-v2/vault-generator-dialog/vault-generator-dialog.component.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/components/src/username-generator.component.ts
Outdated
Show resolved
Hide resolved
libs/tools/generator/components/src/username-generator.component.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
audreyality
reviewed
Jan 30, 2025
audreyality
reviewed
Jan 30, 2025
libs/vault/src/cipher-form/abstractions/cipher-form-generation.service.ts
Show resolved
Hide resolved
Comment on lines
136
to
138
| get getCipherView(): CipherView | null { | ||
| return this.updatedCipherView ?? new CipherView(); | ||
| } |
There was a problem hiding this comment.
🎨 The cipher could be further protected if this is scoped to the uri
There was a problem hiding this comment.
Yes! It would be preferable to have the updatedCipherView protected as possible to ensure the only way it is written to is through the child form controls.
Let's expose it as a read-only uri instead like you've suggested. Thanks for catching that @audreyality!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
1 task
|
@djsmith85 - added you as a reviewer since I'm now one of the authors. 😁 |
djsmith85
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16171
📔 Objective
This PR addresses the issue where the Simplelogin alias generator creates random words instead of including the current website's domain name. The new implementation ensures that aliases are generated based on the active website domain and updates the Simplelogin alias note appropriately.
The alias should be generated in the format [email protected], where website is derived from the current browser tab's domain.
The alias note in Simplelogin should include:
Website: www.website.com. Generated by Bitwarden.
📸 Screenshots
browser.mp4
web.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes