[PM-17393] Bugfix - Resolve breakage of delayed input appearance #13018
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
changed the title
jprusik
commented
Jan 22, 2025
Comment on lines
+40
to
+42
| const timeoutDelay = options?.timeout || 1; | ||
|
|
||
| return globalThis.setTimeout(() => callback(), timeoutDelay); |
There was a problem hiding this comment.
This codepath should only apply to Safari, but since we're here...
|
Great job, no security vulnerabilities found in this Pull Request |
| @@ -948,7 +948,7 @@ export class CollectAutofillContentService implements CollectAutofillContentServ | |||
|
|
|||
| if (!this.mutationsQueue.length) { | |||
| // Collect all mutations and debounce the processing of those mutations by 100ms to ensure we don't process too many mutations at once. | |||
There was a problem hiding this comment.
Should this comment be removed as well?
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #13018 +/- ##
==========================================
- Coverage 35.11% 35.10% -0.01%
==========================================
Files 2990 2990
Lines 91070 91071 +1
Branches 17048 17049 +1
==========================================
Hits 31975 31975
- Misses 56602 56603 +1
Partials 2493 2493 ☔ View full report in Codecov by Sentry. |
differsthecat
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17393
📔 Objective
Resolve case breakage from #12695
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes