-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-17068-Implement Docs for Lit Storybook Instance #12912
PM-17068-Implement Docs for Lit Storybook Instance #12912
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12912 +/- ##
=======================================
Coverage 35.48% 35.48%
=======================================
Files 3007 3007
Lines 90899 90899
Branches 16908 16908
=======================================
Hits 32260 32260
Misses 56137 56137
Partials 2502 2502 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — I was able to check out the branch and run both storybook instances without cross-contamination. 👍
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17068
📔 Objective
Created and implemented relevant Docs for Lit instance of StoryBook components. The docs as of now are hidden and not of use in order to avoid overlap with the main instance of StoryBook which currently picks up all mdx files within browser.
Note: I decided to place all the docs in a hidden directory in order to avoid having extensive hidden files throughout multiple directories. Additionally, once this instance is merged into the main instance we will simply have to drag files into their relevant directories and delete the hidden
.lit-doc
directory.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes