Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13028] - fixed icon width #12721

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[PM-13028] - fixed icon width #12721

merged 1 commit into from
Jan 9, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13028

📔 Objective

This PR fixes an issue with cipher login icons being differing widths by explicitly setting the width as it is now expected that all icons are rendered in equal size.

📸 Screenshots

Before After
Screenshot 2025-01-06 at 2 51 24 PM Screenshot 2025-01-06 at 2 50 44 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 6, 2025 22:55
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsac60d6bc-e2bc-433a-acd0-ce3252fa1ae6

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.27%. Comparing base (ddc8176) to head (d22a209).
Report is 31 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12721      +/-   ##
==========================================
- Coverage   34.29%   34.27%   -0.02%     
==========================================
  Files        2899     2900       +1     
  Lines       89490    89591     +101     
  Branches    16805    16823      +18     
==========================================
+ Hits        30688    30707      +19     
- Misses      56400    56480      +80     
- Partials     2402     2404       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to resolve the initial issue; we should confirm though that all clients that utilize the icon service are rendering the icon at the same size. I confirmed the web app is rendering at 24px but I'm not sure on the desktop app or mobile.

@jaasen-livefront jaasen-livefront merged commit a3e876e into main Jan 9, 2025
88 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-13028-1 branch January 9, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants