Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Jan 6, 2025

๐ŸŽŸ๏ธ Tracking

PM-16804

๐Ÿ“” Objective

Split from #11826 - see details in original PR

Screenshot 2024-12-16 at 11 32 47โ€ฏAM

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 34.26%. Comparing base (15faf52) to head (4a0f2a0).

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lt/popup/components/vault-v2/vault-v2.component.ts 0.00% 28 Missing โš ๏ธ
...-container/vault-list-items-container.component.ts 0.00% 5 Missing โš ๏ธ
...-list-items/autofill-vault-list-items.component.ts 0.00% 3 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12720      +/-   ##
==========================================
- Coverage   34.26%   34.26%   -0.01%     
==========================================
  Files        2900     2900              
  Lines       89591    89621      +30     
  Branches    16823    16831       +8     
==========================================
+ Hits        30700    30707       +7     
- Misses      56487    56510      +23     
  Partials     2404     2404              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 919e4ce3-8a22-4d4e-8ede-c298937004a4

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html: 33 Attack Vector

Base automatically changed from pm-13115 to main January 6, 2025 22:10
@jprusik jprusik force-pushed the pm-16804 branch 4 times, most recently from aeab4b2 to 574523f Compare January 7, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant