-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718
base: main
Are you sure you want to change the base?
refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718
Conversation
…on - Removed email feature flag.
New Issues
Fixed Issues
|
…on - Few more changes.
…on - Rolled back typo fixes.
5e52256
to
763f903
Compare
…on - Rolled back just a few more fixes.
763f903
to
0a28e6a
Compare
…on - Fixed sso component to work with the test.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12718 +/- ##
==========================================
- Coverage 34.29% 34.29% -0.01%
==========================================
Files 2899 2900 +1
Lines 89489 89513 +24
Branches 16805 16798 -7
==========================================
+ Hits 30693 30701 +8
- Misses 56395 56410 +15
- Partials 2401 2402 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
are not always definitely assigned. Either account for null
/undefined
values or ensure they're always definitely assigned by the constructor.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-7326
📔 Objective
This pr is to remove the email verification removal feature flag.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes