Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14289] - vault cipher form - set default owner as organization from collection when possible #12682

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14289

📔 Objective

This PR fixes an issue where if the user goes directly to a collection and creates a new item the default owner was previously being set to the user even if the collection was part of an organization. We now attempt to get the organization from the vaultFilterService using the filtered collectionId when populating the form's initial values to be used when setting the default owner.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 3, 2025 19:12
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details604538e1-c9c0-47ac-be17-69cf953621c0

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (5a36816) to head (e63c52d).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12682      +/-   ##
==========================================
- Coverage   33.74%   33.73%   -0.02%     
==========================================
  Files        2918     2918              
  Lines       90911    90997      +86     
  Branches    17180    17202      +22     
==========================================
+ Hits        30677    30696      +19     
- Misses      57841    57901      +60     
- Partials     2393     2400       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaasen-livefront jaasen-livefront changed the title [PM-14289] - vault cipher form - set default owner as organization from collection if possible [PM-14289] - vault cipher form - set default owner as organization from collection when possible Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant