Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Edge to build Mv3 - Part 2 #12675

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8319

📔 Objective

Remove the dist:edge:mv3 scripts once #12674 is merged so that the workflows on main no longer reference them.

Note that Opera was reverted in #12921, so the scope of the change is only Edge.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Platform/rename-mv3-artifacts-2 Modify Edge and Opera artifacts to build Mv3 - Part 2 Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details268ecb44-ea80-47c4-8418-3e4fc5394b43

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.20%. Comparing base (6f018e1) to head (426d5f1).
Report is 99 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12675      +/-   ##
==========================================
+ Coverage   34.27%   35.20%   +0.92%     
==========================================
  Files        2935     2992      +57     
  Lines       90232    90670     +438     
  Branches    16943    16964      +21     
==========================================
+ Hits        30931    31918     +987     
+ Misses      56837    56288     -549     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

addisonbeck
addisonbeck previously approved these changes Jan 12, 2025
Base automatically changed from platform/rename-mv3-artifacts to main January 12, 2025 21:37
@trmartin4 trmartin4 dismissed addisonbeck’s stale review January 12, 2025 21:37

The base branch was changed.

@trmartin4 trmartin4 marked this pull request as ready for review January 12, 2025 21:37
@trmartin4 trmartin4 requested a review from a team as a code owner January 12, 2025 21:37
@trmartin4 trmartin4 requested review from coroiu and addisonbeck and removed request for coroiu January 12, 2025 21:37
addisonbeck
addisonbeck previously approved these changes Jan 12, 2025
@trmartin4 trmartin4 changed the title Modify Edge and Opera artifacts to build Mv3 - Part 2 Modify Edge to build Mv3 - Part 2 Jan 22, 2025
@trmartin4 trmartin4 requested a review from addisonbeck January 22, 2025 18:11
@trmartin4 trmartin4 merged commit 1e14d6d into main Jan 22, 2025
36 of 37 checks passed
@trmartin4 trmartin4 deleted the platform/rename-mv3-artifacts-2 branch January 22, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants