Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Edge and Opera artifacts to build Mv3 - Part 2 #12675

Draft
wants to merge 1 commit into
base: platform/rename-mv3-artifacts
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 3, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-8319

๐Ÿ“” Objective

Remove the dist:edge:mv3 and dist:opera:mv3 scripts once #12674 is merged so that the workflows on main no longer reference them.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Platform/rename-mv3-artifacts-2 Modify Edge and Opera artifacts to build Mv3 - Part 2 Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ e4e1eec4-5419-4bb4-ba74-4cc2eef8d8e3

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.73%. Comparing base (ddd1534) to head (d08185a).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           platform/rename-mv3-artifacts   #12675      +/-   ##
=================================================================
- Coverage                          33.73%   33.73%   -0.01%     
=================================================================
  Files                               2918     2918              
  Lines                              91001    91001              
  Branches                           17201    17201              
=================================================================
- Hits                               30703    30696       -7     
- Misses                             57898    57905       +7     
  Partials                            2400     2400              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant