[PM-15333] Portable Desktop Fix #12586
Draft
+794
−537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12586 +/- ##
==========================================
- Coverage 35.15% 35.10% -0.05%
==========================================
Files 2984 3002 +18
Lines 90539 91359 +820
Branches 16947 17100 +153
==========================================
+ Hits 31827 32074 +247
- Misses 56251 56780 +529
- Partials 2461 2505 +44 ☔ View full report in Codecov by Sentry. |
|
New Issues (40)Checkmarx found the following issues in this Pull Request
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15333
Fixes #12141
📔 Objective
We need to support someone using the portable Bitwarden app using and signing in on one account then transporting the executable and data files to another computer and unlocking there. Right now we can't do that because we store the access token and refresh token in
Credential Managerwhich is not portable to the new computer.The one problem with this fix is that people who are using the portable app right now on a single computer have their access token in
Credential Managerand after this change the app will be told secure store isn't supported and won't even look there thinking they don't have an access token and they will need to fully login again. @JaredSnider-Bitwarden and I will need to discuss this and maybe we want TokenService to still look there when it's not supported, but I don't love that.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes