Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Account selection dropdown - individual accounts only announced as "Switch account" #12692

Open
1 task done
patrickhlauke opened this issue Jan 5, 2025 · 2 comments · May be fixed by #12693
Open
1 task done

[Accessibility] Account selection dropdown - individual accounts only announced as "Switch account" #12692

patrickhlauke opened this issue Jan 5, 2025 · 2 comments · May be fixed by #12693
Labels
bug desktop Desktop Application

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Use a screen reader
  2. Open the account switching menu/dialog
  3. Set focus to another account

Expected Result

The account has visible text information (e.g. "[email protected], bitwarden.com, locked") - this should be announced as part of the button's accessible name.

Actual Result

The accounts are only announced with generic "Switch account: button". This is because the actual account info is currently mistakenly aria-hidden="true"

clients/apps/desktop/src/app/layout/account-switcher.component.html

Line 79 in 196c1e1

<span class="email" aria-hidden="true">{{ account.value.email }}</span>

This makes the buttons useless for screen reader users, and violates WCAG 2.2 SC 2.5.3 Label in Name (at least)

Screenshots or Videos

Bitwarden desktop and NVDA screen reader speech viewer, showing that the focused button in the account dropdown which includes email address etc info visibly is only announced as 'Switch account: button'

Additional Context

No response

Operating System

Windows

Operating System Version

11

Installation method

Direct Download (from bitwarden.com)

Build Version

2024.12.1

Issue Tracking Info

  • I understand that work is tracked outside of GitHub. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added bug desktop Desktop Application labels Jan 5, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16716

@patrickhlauke patrickhlauke linked a pull request Jan 5, 2025 that will close this issue
Open
@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug desktop Desktop Application
Projects
None yet
Milestone
No milestone
3 participants
@patrickhlauke @bitwarden-bot @SergeantConfused