Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add containerised deployment for the Streamlit dashboard #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add containerised deployment for the Streamlit dashboard #86
Changes from all commits
993064979b8e84File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Run Streamlit as a non-root user.
The image has no
USERinstruction beforeENTRYPOINT, so Streamlit runs asroot. A compromise in the dashboard process would then grant root privileges inside the container.Create a dedicated unprivileged user, assign the required
/appownership, and setUSERbeforeENTRYPOINT.Proposed fix
This finding is also reported by Trivy rule DS-0002.
🤖 Prompt for AI Agents
Source: Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: bittremieuxlab/denovo_benchmarks
Length of output: 5508
🌐 Web query:
Docker Compose up --wait --wait-timeout version introduced support💡 Result:
The
--wait-timeoutoption for thedocker compose upcommand was introduced in Docker Compose v2.17.0 [1]. This feature was implemented via pull request#10276[2][3], which addressed the need to prevent theup --waitcommand from waiting indefinitely for services to reach a "running" or "healthy" state [2]. It is worth noting that during the initial implementation in v2.17.0, there was a temporary regression where the existing--timeoutflag (used for container shutdown) was accidentally renamed to--wait-timeout[1]. This issue was corrected in a subsequent release (v2.17.2) [1].Citations:
updocker/compose#10276🏁 Script executed:
Repository: bittremieuxlab/denovo_benchmarks
Length of output: 2071
🏁 Script executed:
Repository: bittremieuxlab/denovo_benchmarks
Length of output: 1403
Make deployment fail on build or health errors.
Add
set -euo pipefailand replace both Compose commands withdocker compose -f docker-compose.deployment.yaml up --build --detach --wait --wait-timeout 120. Use Docker Compose v2.17.0 or later. Otherwise, poll the container health status explicitly.🤖 Prompt for AI Agents