This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Add low memory and OS kill support for extensions #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Oct 16, 2017
|
Thanks @MatkovIvan, I had a feeling that might be the case. I'll fix it up shortly. |
|
Thanks @dtweston ! Not breaking Xcode 8 unnecessarily would be nice 🙂 |
The UIApplication... notifications are not fired if Hockey is running in the context of an extension. In this case, we should be using the NSExtensionHost... notifications instead.
The UIApplicationDidReceiveMemoryWarningNotification isn't fired when running in an extension, so we need to resort to a lower-level mechanism.
dtweston
force-pushed
the
add_memory_support_for_extensions
branch
from
3d5b3c7
to
c8ad9bc
Compare
|
Looking good! Thx for the contribution!!! |
ElektrojungeAtWork
approved these changes
Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in an extension, HockeyApp doesn't have support for detecting low memory warnings, or for detecting when the process is killed by the OS.
This PR is an attempt to add this functionality.