This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Check .Observed before logging UnobservedTaskException #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Feb 12, 2019
MatkovIvan
approved these changes
Feb 18, 2019
guperrot
reviewed
Feb 18, 2019
|
|
||
| TaskScheduler.UnobservedTaskException += (sender, e) => | ||
| { | ||
| if (!e.Observed) |
There was a problem hiding this comment.
Isn't that check always false? Should we approve #112 instead?
There was a problem hiding this comment.
No. This one looks better to me. It uses a predefined standard api and allows filter exceptions individually.
There was a problem hiding this comment.
I agree with Ivan here.
ElektrojungeAtWork
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix an issue TaskException is sent even if it is marked as Observed