Skip to content

spirv: derive Hash and impl AsRef #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

spirv: derive Hash and impl AsRef #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
021e661
.gitignore: add .idea
Firestar99 Sep 11, 2025
40969f6
spirv: always derive Hash on int vecs
Firestar99 Sep 11, 2025
03758c8
spirv: impl `AsRef` for spirv targets
Firestar99 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.vscode
.idea
**/target
#*.json
*.swp
Expand Down
2 changes: 0 additions & 2 deletions src/f32/coresimd/mat2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,15 +770,13 @@ impl PartialEq for Mat2 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Mat2 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Mat2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/coresimd/mat4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,15 +1851,13 @@ impl PartialEq for Mat4 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 16]> for Mat4 {
#[inline]
fn as_ref(&self) -> &[f32; 16] {
unsafe { &*(self as *const Self as *const [f32; 16]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 16]> for Mat4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 16] {
Expand Down
1 change: 0 additions & 1 deletion src/f32/coresimd/quat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,6 @@ impl PartialEq for Quat {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Quat {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/coresimd/vec3a.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,15 +1798,13 @@ impl Rem<Vec3A> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3A {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3A {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/coresimd/vec4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,15 +1668,13 @@ impl Rem<Vec4> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Vec4 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Vec4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/mat3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,15 +1157,13 @@ impl PartialEq for Mat3 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 9]> for Mat3 {
#[inline]
fn as_ref(&self) -> &[f32; 9] {
unsafe { &*(self as *const Self as *const [f32; 9]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 9]> for Mat3 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 9] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/neon/mat2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,15 +812,13 @@ impl PartialEq for Mat2 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Mat2 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Mat2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/neon/mat4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1856,15 +1856,13 @@ impl PartialEq for Mat4 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 16]> for Mat4 {
#[inline]
fn as_ref(&self) -> &[f32; 16] {
unsafe { &*(self as *const Self as *const [f32; 16]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 16]> for Mat4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 16] {
Expand Down
1 change: 0 additions & 1 deletion src/f32/neon/quat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,6 @@ impl PartialEq for Quat {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Quat {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/neon/vec3a.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1843,15 +1843,13 @@ impl Rem<Vec3A> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3A {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3A {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/neon/vec4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,15 +1700,13 @@ impl Rem<Vec4> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Vec4 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Vec4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/scalar/mat2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,15 +766,13 @@ impl PartialEq for Mat2 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Mat2 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Mat2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/scalar/mat4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1759,15 +1759,13 @@ impl PartialEq for Mat4 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 16]> for Mat4 {
#[inline]
fn as_ref(&self) -> &[f32; 16] {
unsafe { &*(self as *const Self as *const [f32; 16]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 16]> for Mat4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 16] {
Expand Down
1 change: 0 additions & 1 deletion src/f32/scalar/quat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,7 +1205,6 @@ impl PartialEq for Quat {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Quat {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/scalar/vec3a.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1918,15 +1918,13 @@ impl Rem<Vec3A> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3A {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3A {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/scalar/vec4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,15 +1879,13 @@ impl Rem<Vec4> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Vec4 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Vec4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/sse2/mat2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,15 +802,13 @@ impl PartialEq for Mat2 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Mat2 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Mat2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/sse2/mat4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1860,15 +1860,13 @@ impl PartialEq for Mat4 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 16]> for Mat4 {
#[inline]
fn as_ref(&self) -> &[f32; 16] {
unsafe { &*(self as *const Self as *const [f32; 16]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 16]> for Mat4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 16] {
Expand Down
1 change: 0 additions & 1 deletion src/f32/sse2/quat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,6 @@ impl PartialEq for Quat {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Quat {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/sse2/vec3a.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,15 +1851,13 @@ impl Rem<Vec3A> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3A {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3A {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/sse2/vec4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1718,15 +1718,13 @@ impl Rem<Vec4> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Vec4 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Vec4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/vec2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,15 +1762,13 @@ impl Rem<Vec2> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 2]> for Vec2 {
#[inline]
fn as_ref(&self) -> &[f32; 2] {
unsafe { &*(self as *const Self as *const [f32; 2]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 2]> for Vec2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 2] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/vec3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,15 +1908,13 @@ impl Rem<Vec3> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3 {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/wasm32/mat2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,15 +776,13 @@ impl PartialEq for Mat2 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Mat2 {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
unsafe { &*(self as *const Self as *const [f32; 4]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 4]> for Mat2 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/wasm32/mat4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,15 +1851,13 @@ impl PartialEq for Mat4 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 16]> for Mat4 {
#[inline]
fn as_ref(&self) -> &[f32; 16] {
unsafe { &*(self as *const Self as *const [f32; 16]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 16]> for Mat4 {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 16] {
Expand Down
1 change: 0 additions & 1 deletion src/f32/wasm32/quat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,6 @@ impl PartialEq for Quat {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 4]> for Quat {
#[inline]
fn as_ref(&self) -> &[f32; 4] {
Expand Down
2 changes: 0 additions & 2 deletions src/f32/wasm32/vec3a.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,15 +1812,13 @@ impl Rem<Vec3A> for &f32 {
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsRef<[f32; 3]> for Vec3A {
#[inline]
fn as_ref(&self) -> &[f32; 3] {
unsafe { &*(self as *const Self as *const [f32; 3]) }
}
}

#[cfg(not(target_arch = "spirv"))]
impl AsMut<[f32; 3]> for Vec3A {
#[inline]
fn as_mut(&mut self) -> &mut [f32; 3] {
Expand Down
Loading
Loading