Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2][lzmlam] Chinese Translation (#623) #655

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Conversation

syoumoku
Copy link
Contributor

Done. Please review and tell me anything needed to be modified. The translation for Readme.md has already been updated.

Done. Please review. The translation for Readme.md has already been updated.
Copy link
Contributor

@svk31 svk31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use json lint to validate your json before uploading:

https://jsonlint.com/

@@ -114,6 +136,8 @@
"available": "可领取数量",
"referral_link": "你的推荐链接",
"referral_text": "分享此链接给你的朋友参与引荐计划"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing a comma

@@ -175,6 +200,7 @@
"error_invalid": "该资产不能使用",
"market": "关注的市场交易对",
"precision_warning": "警告:创建后该数值将无法更改。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs a comma at the end

"activity": "活动记录",
"eq_value_header": "市值 ({asset})",
"qty": "数量",
"total": "总额 ({asset})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs a comma at the end

@@ -664,11 +703,12 @@
"issuer": "发行人",
"precision": "精度",
"prediction": "预测市场资产"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs a comma at the end

@@ -114,6 +136,8 @@
"available": "可领取数量",
"referral_link": "你的推荐链接",
"referral_text": "分享此链接给你的朋友参与引荐计划"
"fees_paid":"所有已付手续费",
"fees_cashback": "手续费统计",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fees_paid key already exists in this object

@@ -114,6 +136,8 @@
"available": "可领取数量",
"referral_link": "你的推荐链接",
"referral_text": "分享此链接给你的朋友参与引荐计划"
"fees_paid":"所有已付手续费",
"fees_cashback": "手续费统计",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fees_cashback also already exists higher up

},
"propose": "提交",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "propose" key is also set in line 1268

},
"propose": "提交",
"cancel": "取消",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cancel" also already exists elsewhere

Hi, svk. Thanks for your patience. Now it is valid.
@svk31 svk31 merged commit 3361d56 into bitshares:staging Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants