Fix #374 #375
Merged
Fix #374 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svk31
suggested changes
Sep 12, 2017
| @@ -34,7 +34,8 @@ | |||
| "help": "Help", | |||
| "locked_tip": "<br/>Click to login by unlocking your wallet.<br/><br/>Closing the browser window will also log you out.", | |||
| "unlocked_tip": "<br/>Click to log out by locking your wallet.<br/><br/>Closing the browser window will also log you out.", | |||
| "account_notify": "The active account is now %(account)s" | |||
| "account_notify": "The active account is now %(account)s", | |||
| "account_value": "ACCOUNT VALUE" | |||
There was a problem hiding this comment.
Please change ACCOUNT VALUE to normal lowercase "Account value"
There was a problem hiding this comment.
Thanks, I pushed a new commit
| @@ -99,7 +100,7 @@ | |||
| "show_ignored": "Show hidden accounts", | |||
| "hide_ignored": "Hide hidden accounts", | |||
| "accounts": "Accounts", | |||
| "estimate_value": "Estimated account value", | |||
| "estimate_value": "Estimated ACCOUNT VALUE", | |||
svk31
suggested changes
Sep 12, 2017
| @@ -99,7 +100,7 @@ | |||
| "show_ignored": "Show hidden accounts", | |||
| "hide_ignored": "Hide hidden accounts", | |||
| "accounts": "Accounts", | |||
| "estimate_value": "Estimated account value", | |||
| "estimate_value": "Estimated Account value", | |||
There was a problem hiding this comment.
Hate to be a stickler, but please make Account lowercase also.
|
Sorry, I did not pay attention to the contributing guide has changed. I merged the branch |
svk31
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #374
Updated text 'Balance' to 'ACCOUNT VALUE'