Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appveyor and action bug #3451

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix appveyor and action bug #3451

merged 1 commit into from
Jan 27, 2022

Conversation

xiangxn
Copy link
Contributor

@xiangxn xiangxn commented Jan 27, 2022

fix appveyor and action bug

Fix 'appveyor' and 'action' build failures due to network issues.

@xiangxn xiangxn merged commit 4ea28b0 into develop Jan 27, 2022
@xiangxn xiangxn deleted the fix-ci-actions-bug branch January 27, 2022 06:58
@sschiessl-bcp
Copy link
Contributor

Should the --frozen-lockfile not also remain, plus the concurrency?

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 27, 2022

In the case of a fast network, concurrency will cause the installation of dependencies to fail, which is a yarn problem.

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 27, 2022

Although upgrading yarn can solve this problem, however, because the project depends on many old packages, upgrading yarn may cause new problems.

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 27, 2022

There is also a dependency package using node-sass in the project, which has poor cross-platform performance.

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 27, 2022

frozen-lockfile can still be preserved, even if it is not preserved, it will work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants