Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.25][startailcoon] BTS trade button missing from portfolio view #658

Closed
jonnybitcoin opened this issue Oct 28, 2017 · 5 comments
Closed

[.25][startailcoon] BTS trade button missing from portfolio view #658

jonnybitcoin opened this issue Oct 28, 2017 · 5 comments
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone
171101

Comments

@jonnybitcoin
Copy link

BTS trade button missing (not enabled) from portfolio view.
Even when you have a balance.
@startailcoon
Copy link
Contributor

I think this is because the trade button on other assets assume you wish to trade that asset towards BTS. Since you can't trade BTS:BTS it's disabled.

The question is what other asset you should wish to come up when you select the BTS trade button.

One solution would be to make the button trade against the selected default unit that the user has. A user that has bitUSD as default unit would get a button to BTS:bitUSD.

A user that doesn't have any default unit would not get a button for trading.

@wmbutler wmbutler changed the title BTS trade button missing from portfolio view [.25] BTS trade button missing from portfolio view Oct 28, 2017
@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Oct 28, 2017
@wmbutler wmbutler added this to the 171101 milestone Oct 28, 2017
@wmbutler
Copy link
Contributor

One solution would be to make the button trade against the selected default unit that the user has. A user that has bitUSD as default unit would get a button to BTS:bitUSD.

Yes. The user always has a default unit, so this is a great idea.

@startailcoon
Copy link
Contributor

I can claim this. May get this done before the release next week

@wmbutler
Copy link
Contributor

Awesome. It's yours.

@wmbutler wmbutler changed the title [.25] BTS trade button missing from portfolio view [.25][startailcoon] BTS trade button missing from portfolio view Oct 28, 2017
@startailcoon startailcoon mentioned this issue Oct 29, 2017
Merged
@happyconcepts
Copy link
Contributor

#217

svk31 pushed a commit that referenced this issue Oct 30, 2017
@startailcoon @svk31
Fix Issue #658 - BTS Trade Button (#662)
5a91d7c 
* View Trading Icon for BTS
- Only when Preferred Unit is not BTS
- Otherwise, display an empty cell

* Small cleaning
@svk31 svk31 closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Milestone
171101
Development

No branches or pull requests
5 participants
@wmbutler @svk31 @startailcoon @happyconcepts @jonnybitcoin