Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] Display Status based upon block count incrementing #543

Closed
5 tasks
wmbutler opened this issue Oct 10, 2017 · 8 comments
Closed
5 tasks

[1] Display Status based upon block count incrementing #543

wmbutler opened this issue Oct 10, 2017 · 8 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@wmbutler
Copy link
Contributor

We need a foolproof way to know if a user is connected or not. We should be able to use this during troubleshooting with clients by saying: Look at the lower right corner. Does it say connected or disconnected?

  • Add the footer status bar and version to the exchange screen (it's currently missing)
  • Get rid of the check box icon
  • Display words connected / disconnected depending upon block count incrementing. It's possible for the socket to be connected without an incrementing blockcount so the socket alone is not a foolproof indicator.

screen shot 2017-10-10 at 8 57 20 am

  • Current Look

screen shot 2017-10-10 at 8 57 09 am

  • Proposed look

screen shot 2017-10-10 at 9 22 44 am
screen shot 2017-10-10 at 9 21 38 am

@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Oct 10, 2017
@wmbutler wmbutler added this to the 171015 milestone Oct 10, 2017
@svk31
Copy link
Contributor

svk31 commented Oct 10, 2017

There actually is some logic to show a warning when the blockchain status is out of sync, but it appears to have been broken some time ago.

I think your version is much cleaner anyway.

The footer was hidden in the exchange to gain some vertical height.

@wmbutler
Copy link
Contributor Author

I hope you can add the footer back because it will help us troubleshoot if the user happens to be in the exchange.

@wmbutler wmbutler changed the title Display Status based upon block cout incrementing Display Status based upon block count incrementing Oct 10, 2017
@calvinfroedge calvinfroedge self-assigned this Oct 10, 2017
@calvinfroedge
Copy link
Contributor

@wmbutler Should there be some sort of timeout logic where if a new block is not received in x seconds, we show disconnected?

Or do we show connected indefinitely as soon as block count increments the first time?

@wmbutler
Copy link
Contributor Author

I think you should look at a 10-second interval. This would mean that if 10 seconds pass without a block increment, you would report a down condition.

Conversely, you would report and up condition if the opposite is true.

@wmbutler wmbutler changed the title Display Status based upon block count incrementing [1] Display Status based upon block count incrementing Oct 11, 2017
@calvinfroedge
Copy link
Contributor

@svk31 Where can I check that the block count is incrementing? I can figure this out on my own but I will need more time.

@svk31
Copy link
Contributor

svk31 commented Oct 13, 2017

Actually, the API node being out of sync is probably the error you're trying to capture here, and it's different from "Disconnected". If you're disconnected you'll be redirected to the init-error page.

We already have a warning message for that, but I see the logic isn't working very well. If you don't mind @calvinfroedge I can take this on.

@svk31
Copy link
Contributor

svk31 commented Oct 13, 2017

I looked into why the synced prop of Footer.jsx was no longer useful and made some changes that I've just pushed, you should be able to take it from there. Synced will now become false if the latest block is more than 5s old compared to the user's local time.

@svk31 svk31 closed this as completed in c8cf1bc Oct 14, 2017
@svk31 svk31 self-assigned this Oct 14, 2017
@svk31
Copy link
Contributor

svk31 commented Oct 14, 2017

Wanted to get this in before the deadline tomorrow so I just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

3 participants