-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1] Display Status based upon block count incrementing #543
Comments
There actually is some logic to show a warning when the blockchain status is out of sync, but it appears to have been broken some time ago. I think your version is much cleaner anyway. The footer was hidden in the exchange to gain some vertical height. |
I hope you can add the footer back because it will help us troubleshoot if the user happens to be in the exchange. |
@wmbutler Should there be some sort of timeout logic where if a new block is not received in x seconds, we show disconnected? Or do we show connected indefinitely as soon as block count increments the first time? |
I think you should look at a 10-second interval. This would mean that if 10 seconds pass without a block increment, you would report a down condition. Conversely, you would report and up condition if the opposite is true. |
@svk31 Where can I check that the block count is incrementing? I can figure this out on my own but I will need more time. |
Actually, the API node being out of sync is probably the error you're trying to capture here, and it's different from "Disconnected". If you're disconnected you'll be redirected to the init-error page. We already have a warning message for that, but I see the logic isn't working very well. If you don't mind @calvinfroedge I can take this on. |
I looked into why the synced prop of Footer.jsx was no longer useful and made some changes that I've just pushed, you should be able to take it from there. Synced will now become false if the latest block is more than 5s old compared to the user's local time. |
Wanted to get this in before the deadline tomorrow so I just fixed it. |
We need a foolproof way to know if a user is connected or not. We should be able to use this during troubleshooting with clients by saying: Look at the lower right corner. Does it say connected or disconnected?
The text was updated successfully, but these errors were encountered: