Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.25][svk] OrderBook scroll bar(and others) should be always visible #498

Closed
Xeldal opened this issue Oct 5, 2017 · 7 comments
Closed
Assignees
Labels
[3] Enhancement Classification indicating a change to the functionality of the existing imlementation
Milestone

Comments

@Xeldal
Copy link
Contributor

Xeldal commented Oct 5, 2017

Using LightClient bitshares.171003 (windows7x64)

Suggestion: make scroll bars always visible.

Currently you are able to scroll the buy and sell order books. After scrolling, the scroll bar disappears and it may give the impression the highest bid or lowest ask is something that it is not. In particular with the vertical orderbooks, because you can scroll so far. The orders nearest the center can be vastly different from whats actually the highest and lowest bid/ask.

It's a minor distinction and really should be the users responsibility but it's happened to me several times looking at the book and getting confused as to why the number are so far off. It's also easy to have mistakenly scrolled one of the books while trying to scroll the main page. Having the scroll bar always visible is an easy clue.

Should be an easy fix that adds a good deal of UX benefit. Just make the scroll bar always visible.

@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

I would disagree. I really don't like to see scroll bars when they are not actively scrolling.

@Xeldal
Copy link
Contributor Author

Xeldal commented Oct 5, 2017

Nothing to do with whether you like to see them or not. It's about getting information and visual clues to the user. It is a point of confusion. There is currently no visual indication that the book is adjusted off screen. If you don't like the minuscule bar, at least for the sake of usability get rid of the possibility to scroll.

@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

Scrollbar visibility is determined by the browser. We have no control over this.

@wmbutler wmbutler closed this as completed Oct 5, 2017
@Xeldal
Copy link
Contributor Author

Xeldal commented Oct 5, 2017

You are too quick to close an issue. You must really have a thing with scroll bars?
This issue is referring to the Lightwallet. Which browser is that?
Tested in Crome FF and Lightwallet. The exchange screen has a scroll bar always visible for the main page and then the smaller tables have their own scrollbars that disappear. Clearly this is not a browser controlled setting. As the code is showing both. It is either the type of scroll bar you are using or an attribute setting. {:isVisible} or {:onHover} If you want it you can get it. So don't bullshit with "We have no control over this"

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Oct 5, 2017
@wmbutler wmbutler reopened this Oct 5, 2017
@svk31
Copy link
Contributor

svk31 commented Oct 15, 2017

The light client is a Chromium browser so equivalent to Chrome. Scrollbars are different between operating systems which is probably why Bill can't see the difference in scrollbars, they all look the same on Macs but in Windows and Linux you'll see two differen types of scrollbars in the GUI.

The orderbook and most other tables use a special scrolling library that visually mimics the scrollbars of OSX. The reason for that is to give us better control of how and where scrolling is allowed. and also for the fact that they are hidden unless you want to use them, which makes for a much cleaner visual experience.

@Xeldal
Copy link
Contributor Author

Xeldal commented Oct 15, 2017

I agree it looks cleaner, but it is undesirable from a usability standpoint. Look at Poloniex for example. Their interface is very close to ours. Their scroll bars are always visible. They use a similar style of small and unobtrusive but always visible. The standard windows scrollbar I agree would be huge and obnoxious. We don't need the ability to click on the scroll bar, so it doesn't need to be big. We just need to see it. So we have some visual clue when we are not looking at the top of the book.

@svk31 svk31 changed the title OrderBook scroll bar(and others) should be always visible [0.25][svk] OrderBook scroll bar(and others) should be always visible Oct 16, 2017
@svk31 svk31 self-assigned this Oct 16, 2017
@svk31 svk31 added this to the 171101 milestone Oct 16, 2017
@svk31
Copy link
Contributor

svk31 commented Oct 16, 2017

Decided to implement this since it's a quick fix and does make sense.

image

@svk31 svk31 closed this as completed Oct 16, 2017
svk31 added a commit that referenced this issue Oct 30, 2017
* Update version #

* Fix #498: Keep scrollbars visible, restore perfect scrollbar to main exchange div

* Fix #589: Openledger deposit address shown as unknown

* Only store valid deposit addresses #589

* Fix setting of max_market_fee in asset create/update

* First pass at showing market fees in exchange #581

* Add a tooltip explaining the market fee
CryptoBridge pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 21, 2017
* Update version #

* Fix bitshares#498: Keep scrollbars visible, restore perfect scrollbar to main exchange div

* Fix bitshares#589: Openledger deposit address shown as unknown

* Only store valid deposit addresses bitshares#589

* Fix setting of max_market_fee in asset create/update

* First pass at showing market fees in exchange bitshares#581

* Add a tooltip explaining the market fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Enhancement Classification indicating a change to the functionality of the existing imlementation
Projects
None yet
Development

No branches or pull requests

3 participants