Skip to content

[0.25] STAGING - Add contact link throws error #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahdigital opened this issue Jun 20, 2018 · 0 comments
Closed

[0.25] STAGING - Add contact link throws error #1612

ahdigital opened this issue Jun 20, 2018 · 0 comments
Assignees
@svk31
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180706

Comments

@ahdigital
Copy link
Contributor

Describe the bug

The 'Add contact' link shown in the burger menu does nothing when clicked, and there is not an account name shown in the top right hand side of the header.

To Reproduce

Steps to reproduce the behavior:

  1. Clear cache and make sure no account is shown in top right
  2. Open burger menu
  3. Click on 'Add contact'
  4. See error in console

Console error

Uncaught Error: Invalid account name: null

Expected behavior

If there is no account name selected don't show the 'Add contact' link.

Desktop

  • OS: Windows
  • Browser: Chrome
  • Version: 67
@startailcoon startailcoon added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Jun 20, 2018
@startailcoon startailcoon added this to the 180701 milestone Jun 20, 2018
@startailcoon startailcoon changed the title STAGING - Add contact link throws error [0.25] STAGING - Add contact link throws error Jun 20, 2018
svk31 added a commit that referenced this issue Jun 22, 2018
@svk31
Fix #1612 and fix #1611: Hide/disable header dropdown links when not …
3446630 
…appropriate
@svk31 svk31 closed this as completed Jun 22, 2018
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
Fix bitshares#1612 and fix bitshares#1611: Hide/disable header dropdo…
a5dc8ac 
…wn links when not appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svk31 svk31

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180706
Development

No branches or pull requests
3 participants
@ahdigital @svk31 @startailcoon