Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1] 'Create account' doesn't jump user to form #1610

Closed
ahdigital opened this issue Jun 20, 2018 · 7 comments
Closed

[1] 'Create account' doesn't jump user to form #1610

ahdigital opened this issue Jun 20, 2018 · 7 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@ahdigital
Copy link
Contributor

Describe the UX issue

These are mostly UX issues with mobile:

Part A) As a user I want to create an account, but when I click the 'create account' button from the landing page I don't notice the form because it loads in close to/below the viewport bottom whilst the UI.

Part B) As a user I want to create an account, but when I click the 'create account' link from the burger menu I don't see the form because the landing page appears above it, and at a glance it looks like I need to press 'create account' again.

The account creation pages used to load in separate-looking views, but now they're combined with the landing page/language selection view and thus, pushed way down the page on mobile.

To Reproduce

Steps to reproduce the behavior for part A:

  1. Go to Bitshares landing page with the language selection
  2. Click on 'Create account' or 'advanced form'
  3. User can barely notice a form loaded in

Steps to reproduce the behavior for part B:

  1. Go to any other page and click the burger menu
  2. Click on 'Create account'
  3. User see landing page and thinks another tap is required on 'create account' button

Expected behavior

If the forms are going to be displayed beneath the landing page UI, the user should be scrolled down to view them when they're requested.

Screenshots

Part A)
create-account-1

Part B)
create-account-2

Smartphone

  • Device: S8
  • OS: Android
  • Browser: Chrome
  • Version: 67

Simulated

  • Resolution: iPhone 6/7/8
  • Browser: Chrome
  • Version: 67
@startailcoon startailcoon added the [3] Feature Classification indicating the addition of novel functionality to the design label Jun 20, 2018
@startailcoon startailcoon added this to the 180701 milestone Jun 20, 2018
@startailcoon
Copy link
Contributor

Using an anchor and the new react-scroll library, this would be an easy task to complete.

@startailcoon startailcoon changed the title STAGING - 'Create account' doesn't jump user to form [0.5] STAGING - 'Create account' doesn't jump user to form Jun 20, 2018
@sschiessl-bcp
Copy link
Contributor

Was this a newly introduced bug or is this already like that in the current release?

I understand it's only a small bug and quite easily fixable, and maybe I am a bit too gusty, but features should not be allowed into current release candidate as it blurs the intent. We don't want to give the impression that anything goes and can be hotfixed into the candidate.

@startailcoon startailcoon changed the title [0.5] STAGING - 'Create account' doesn't jump user to form [0.5] 'Create account' doesn't jump user to form Jun 21, 2018
@startailcoon
Copy link
Contributor

@sschiessl-bcp I forgot to remove the "staging" name from the user issue. This is of course not something that would be fixed to the staging branch. I belelive this is something that has always been there, and is thus labeled as a feature.

Only bugs should be pushed to staging.

@ahdigital
Copy link
Contributor Author

Was this a newly introduced bug or is this already like that in the current release?

I believe this is something that has always been there

In my original post I mentioned the on boarding pages used to load as separate pages. Check the current live release against staging and you can see they are different.

@wmbutler wmbutler changed the title [0.5] 'Create account' doesn't jump user to form [1] 'Create account' doesn't jump user to form Jun 30, 2018
@wmbutler
Copy link
Contributor

Somebody want to claim this?

@startailcoon
Copy link
Contributor

Sure, I'll fix this

@startailcoon
Copy link
Contributor

bitshares-scrolloncreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

4 participants