Skip to content

[1] Propose transfer of BTS asset has precision issue #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tianyekuo opened this issue May 25, 2018 · 1 comment
Closed

[1] Propose transfer of BTS asset has precision issue #1556

tianyekuo opened this issue May 25, 2018 · 1 comment
Assignees
@startailcoon
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180615

Comments

@tianyekuo
Copy link
Contributor

Describe the bug
When send BTS asset to other user with proposal, the quantity will be round with 0 precision.

To Reproduce
Steps to reproduce the behavior:

  1. Click Send(legacy)
  2. Input "From" field with a mutil-signed account.
  3. Click Propose link
  4. Input 1.1 BTS
  5. Begin to propose
  6. Check the confirm dialog

Expected behavior
Step 6 show proposed operations: Transfer 1.1 BTS

Issues
Step 6 actually show “Transfer 1 BTS”.
If transfer 1.5 BTS, then the confirmation page show "Transfer 2 BTS".
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label May 29, 2018
@wmbutler wmbutler changed the title Propose transfer of BTS asset has precision issue [1] Propose transfer of BTS asset has precision issue May 29, 2018
@wmbutler wmbutler added this to the 180605 milestone May 29, 2018
@startailcoon startailcoon self-assigned this Jun 8, 2018
@startailcoon
Copy link
Contributor

Removing decimalOffset for proposed transaction solves this issue.

Preview below views that BTS, USD and Peerplays are rounded as expected even without this code.

bitshares-propose

@startailcoon startailcoon mentioned this issue Jun 8, 2018
Merged
svk31 pushed a commit that referenced this issue Jun 11, 2018
@startailcoon @svk31
Fix #1556: Remove forced decimalOffset on Proposed Transaction
bf6331d
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@startailcoon @svk31
Fix bitshares#1556: Remove forced decimalOffset on Proposed Transaction
8aae046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startailcoon startailcoon

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180615
Development

No branches or pull requests
3 participants
@wmbutler @tianyekuo @startailcoon