Skip to content

[3] Support new operations in account activities and block explorer #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyekuo opened this issue May 22, 2018 · 12 comments
Closed

[3] Support new operations in account activities and block explorer #1547

tianyekuo opened this issue May 22, 2018 · 12 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [6] Core Impact flag identifying related to bitshares-core [7] Finalized Administartion flag, notifies hours are finalized
Milestone

Comments

@tianyekuo
Copy link
Contributor

Describe the bug
bsip-0027 Asset Issuer Reclaim Fee Pool Funds: backend support the API in the next release, frontend should support the new operation.

To Reproduce
Steps to reproduce the behavior:

  1. call the api by the latest cli_wallet: claim_asset_fee_pool GDEX123ABC0 100 true
  2. Open the user activity page
  3. Check the latest record
  4. Click the block num in the record
  5. Check the block info page

Expected behavior
Step3 and step5 should show the user claim asset fee pool funds info.

Screenshots
Activity page:
activity

Block page:
https://testnet.bitshares.eu/block/17531683
block

@svk31 svk31 self-assigned this May 22, 2018
@wmbutler wmbutler added this to the 180605 milestone May 22, 2018
@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label May 22, 2018
@wmbutler wmbutler changed the title Support claim asset fee pool operation [1] Support claim asset fee pool operation May 22, 2018
@abitmore abitmore changed the title [1] Support claim asset fee pool operation [1] Support claim asset fee pool operation in account activities and block explorer May 25, 2018
@abitmore abitmore changed the title [1] Support claim asset fee pool operation in account activities and block explorer [1] Support new operations in account activities and block explorer May 25, 2018
@abitmore
Copy link
Member

Updated #1493 to include this.

@startailcoon
Copy link
Contributor

startailcoon commented Jun 13, 2018

New OPs to support in UI from BitsharesJS

  • bid_collateral: 45,
  • fba_distribute: 44,
  • execute_bid: 46,
  • asset_claim_pool: 47,
  • asset_update_issuer: 48

@abitmore
Copy link
Member

Thank you @startailcoon.

  • "claim pool asset" sounds a bit strange. Perhaps better name it "claim asset fee pool"?
  • I think it's better to use "ACCOUNT claimed x YYY from asset ASSERT's fee pool" as description
  • "transfered" is typo, should be "transferred".

@startailcoon
Copy link
Contributor

@abitmore new snaps according to your suggestions
bild

bild

@startailcoon
Copy link
Contributor

OP 45 - bid_collateral

Block TX

image

Account History

Since I can't see the tx in the account history, since it's to old, this is how it would look like

abit updated collateral with 2,000,000 BTS for 79.813058 bitGOLD

OP 46 - execute_bid

This operation is a virtual OP and isn't visible in the block. One is included in block 22513611 for operation 1.11.102370951.

Account History

I'm not sure if this is visible in the account transaction history, but if so it needs a translation for the following.

[46,{"fee":{"amount":0,"asset_id":"1.3.0"},"bidder":"1.2.12376","debt":{"amount":"283881176519","asset_id":"1.3.0"},"collateral":{"amount":79813058,"asset_id":"1.3.106"}}]

OP 44 - fba_distribute

This operation is related to stealth operations, and handles routing of fees for FBAs (fee backed assets).

This operation is also only a virtual OP, and isn't visible in the block explorer. One is included in block 22513611 for operation 1.11.219853425

Account History

This is the string that needs a translation. Note that it doesn't have any asset_id parameters, only an amount and a fba_id. The fba_id gives the asset_id relation for the fee backed asset, in this case it's STEALTH. The amount is the base asset (I presum).

[44,{"fee":{"amount":0,"asset_id":"1.3.0"},"account_id":"1.2.107093","fba_id":"2.16.1","amount":900000}]

I propose we use something like this
Deducted 9 BTS from fee backed asset STEALTH

@abitmore
Copy link
Member

@startailcoon all these entries should be in account history.

For description for the 2 bid related operations please check BSIP18.

For the FBA operation, please check histories of these accounts:

Unfortunately I didn't find technical specification documentation about it. Related code in bitshares-core is here.

svk31 pushed a commit that referenced this issue Jun 15, 2018
* Support New OPs
- asset_claim_pool: 47
- asset_update_issuer: 48

* Translation fixes
@startailcoon startailcoon added the [6] Core Impact flag identifying related to bitshares-core label Jun 19, 2018
@wmbutler wmbutler modified the milestones: 180615, 180701 Jun 20, 2018
@wmbutler
Copy link
Contributor

Was your time fair on this?

@startailcoon
Copy link
Contributor

I still need to fix the remaining OPs. Keep this open and increase to 3 hours in total.

It will need a second PR to be done.

@wmbutler wmbutler changed the title [1] Support new operations in account activities and block explorer [3] Support new operations in account activities and block explorer Jun 30, 2018
@wmbutler wmbutler modified the milestones: 180706, 180721 Jul 9, 2018
@wmbutler wmbutler modified the milestones: 180720, 180803 Jul 23, 2018
@wmbutler wmbutler modified the milestones: 180801, 180815 Aug 6, 2018
@startailcoon
Copy link
Contributor

I will still find time to look at this and verify the need for any missing logic. Pushing it to next release for now.

@startailcoon startailcoon modified the milestones: 180815, 180905 Aug 19, 2018
@wmbutler wmbutler modified the milestones: 180905, 180919 Sep 13, 2018
@wmbutler wmbutler modified the milestones: 180919, 181003 Sep 25, 2018
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
* Support New OPs
- asset_claim_pool: 47
- asset_update_issuer: 48

* Translation fixes
@startailcoon
Copy link
Contributor

OP 45, 46 implemented by PR #2248

@startailcoon
Copy link
Contributor

OP 44, fba_distribute

I need some suggestions on how we should display this OP.

OP is virtual, and contains the following

{
  "account_id": "1.2.102338",
  "amount": 24314,
  "fba_id": "2.16.2",
  "fee": {
    "amount": 0,
    "asset_id": "1.3.0"
  }
}

It contains the account, amount and a link to the fba asset id.
Fetching the data from the fba asset id to fetch the details for it.

What does this operation actually do? Where does the asset go that is distributed? Is the following enough information and is it correctly displayed?

bild

@startailcoon startailcoon added this to the 181212 milestone Dec 15, 2018
@startailcoon
Copy link
Contributor

All possible and necessary OPs included by today. OP44 isn't widely used.

@startailcoon startailcoon added the [7] Finalized Administartion flag, notifies hours are finalized label Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design [6] Core Impact flag identifying related to bitshares-core [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Development

No branches or pull requests

5 participants