-
Notifications
You must be signed in to change notification settings - Fork 569
[3] Support new operations in account activities and block explorer #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Updated #1493 to include this. |
New OPs to support in UI from BitsharesJS
|
Thank you @startailcoon.
|
@abitmore new snaps according to your suggestions |
OP 45 - bid_collateralBlock TXAccount HistorySince I can't see the tx in the account history, since it's to old, this is how it would look like
OP 46 - execute_bidThis operation is a virtual OP and isn't visible in the block. One is included in block 22513611 for operation 1.11.102370951. Account HistoryI'm not sure if this is visible in the account transaction history, but if so it needs a translation for the following.
OP 44 - fba_distributeThis operation is related to stealth operations, and handles routing of fees for FBAs (fee backed assets). This operation is also only a virtual OP, and isn't visible in the block explorer. One is included in block 22513611 for operation 1.11.219853425 Account HistoryThis is the string that needs a translation. Note that it doesn't have any asset_id parameters, only an amount and a fba_id. The
I propose we use something like this |
@startailcoon all these entries should be in account history. For description for the 2 bid related operations please check BSIP18. For the FBA operation, please check histories of these accounts:
Unfortunately I didn't find technical specification documentation about it. Related code in bitshares-core is here. |
* Support New OPs - asset_claim_pool: 47 - asset_update_issuer: 48 * Translation fixes
Was your time fair on this? |
I still need to fix the remaining OPs. Keep this open and increase to 3 hours in total. It will need a second PR to be done. |
I will still find time to look at this and verify the need for any missing logic. Pushing it to next release for now. |
* Support New OPs - asset_claim_pool: 47 - asset_update_issuer: 48 * Translation fixes
OP 45, 46 implemented by PR #2248 |
OP 44, fba_distributeI need some suggestions on how we should display this OP. OP is virtual, and contains the following
It contains the account, amount and a link to the fba asset id. What does this operation actually do? Where does the asset go that is distributed? Is the following enough information and is it correctly displayed? |
All possible and necessary OPs included by today. OP44 isn't widely used. |
Describe the bug
bsip-0027 Asset Issuer Reclaim Fee Pool Funds: backend support the API in the next release, frontend should support the new operation.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Step3 and step5 should show the user claim asset fee pool funds info.
Screenshots

Activity page:
Block page:

https://testnet.bitshares.eu/block/17531683
The text was updated successfully, but these errors were encountered: