Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Hardcoded Network Percentage Fee #1517

Closed
clockworkgr opened this issue May 17, 2018 · 2 comments
Closed

[1] Hardcoded Network Percentage Fee #1517

clockworkgr opened this issue May 17, 2018 · 2 comments
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks
Milestone
180525

Comments

@clockworkgr
Copy link
Member

The network percentage fee (20%) is hardcoded into the UI.

See: https://github.com/bitshares/bitshares-ui/blame/staging/app/components/Blockchain/Fees.jsx?L72-L77

As this is a settable/customisable property in the blockchain, it should be read from global properties.
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks and removed [3] Feature Classification indicating the addition of novel functionality to the design labels May 17, 2018
@wmbutler wmbutler added this to the 180525 milestone May 17, 2018
@wmbutler wmbutler changed the title Hardcoded Network Percentage Fee [1] Hardcoded Network Percentage Fee May 17, 2018
@clockworkgr
Copy link
Member Author

Can I also claim this?

@clockworkgr
Copy link
Member Author

Meh, it's a small thing, might as well get it over with.

Done in #1524

@svk31 svk31 closed this as completed in fbc4ba0 May 18, 2018
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
Merge pull request bitshares#1524 from clockworkgr/1517-remove-hardco…
6dc278a 
…ded-fee-perc

Fix bitshares#1517 - Remove hardcoded network fee percentage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks
Projects
None yet
Milestone
180525
Development

No branches or pull requests
2 participants
@wmbutler @clockworkgr