Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5][svk31] Display page not found for non-existent markets #1463

Closed
2 tasks
wmbutler opened this issue Apr 24, 2018 · 1 comment
Closed
2 tasks

[0.5][svk31] Display page not found for non-existent markets #1463

wmbutler opened this issue Apr 24, 2018 · 1 comment
Assignees
@svk31
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180525

Comments

@wmbutler
Copy link
Contributor

wmbutler commented Apr 24, 2018 •
edited
Loading

If a market does not exist, for instance, foo_foo, handle it gracefully and quickly. In this case, the user attempted to navigate directly to market foo_foo and the browser connected to the chainstore of the node and hung.

  • UX the empty state (Market does not exist). Should we load all the elements of the Exchange but leave them empty with the chosen foo/foo in the upper left? This would allow the user to search for an appropriate market with the new market finder menu dropdown.
  • Be sure to handle case sensitivity and rewrite the lowercase to uppercase.

market
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Apr 24, 2018
@wmbutler wmbutler added this to the 180515 milestone Apr 24, 2018
@wmbutler wmbutler changed the title [2][ahdigital][5] Properly handle non-existent market [2][ahdigital][5] Properly handle non-existent markets Apr 24, 2018
@svk31
Copy link
Contributor

svk31 commented Apr 25, 2018

Here's a 30s solution:

image

svk31 added a commit that referenced this issue Apr 25, 2018
@svk31
#1463: Capitalize marketID params, return 404 if assets are the same
555acb9
@svk31 svk31 closed this as completed in 271e051 Apr 25, 2018
@svk31 svk31 changed the title [2][ahdigital][5] Properly handle non-existent markets [0.5][svk31][5] Properly handle non-existent markets Apr 25, 2018
@svk31 svk31 self-assigned this Apr 25, 2018
@wmbutler wmbutler changed the title [0.5][svk31][5] Properly handle non-existent markets [0.5][svk31] Display page not found for non-existent markets Apr 25, 2018
@wmbutler wmbutler mentioned this issue Apr 25, 2018
Closed
2 tasks
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
bitshares#1463: Capitalize marketID params, return 404 if assets are …
7ff4da0 
…the same
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
Fix bitshares#1463: Handle non-existant assets in exchange and asset …
1b9209a 
…pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svk31 svk31

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180525
Development

No branches or pull requests
2 participants
@wmbutler @svk31