Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_variant::set_which() rejects negative param #9

Merged
merged 1 commit into from
Jan 21, 2018
Merged

static_variant::set_which() rejects negative param #9

merged 1 commit into from
Jan 21, 2018

Conversation

abitmore
Copy link
Member

No description provided.

pmconrad
pmconrad approved these changes Jan 20, 2018
View reviewed changes
Copy link

@pmconrad pmconrad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. _tag can only become negative in init() if X is not in Types, and that is checked before init() is called.
(Ignoring the case when Types has more than MAXINT members.)

@abitmore abitmore mentioned this pull request Jan 20, 2018
Merged
@pmconrad pmconrad mentioned this pull request Jan 21, 2018
Closed
oxarbitrage
oxarbitrage approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find.

@oxarbitrage oxarbitrage merged commit a1e1599 into master Jan 21, 2018
This was referenced Jan 21, 2018
Closed
Merged
@abitmore abitmore deleted the abitmore-patch-1 branch February 14, 2018 11:27
oxarbitrage pushed a commit to oxarbitrage/bitshares-fc that referenced this pull request Mar 23, 2018
Time execution of rpc API call and log long executing calls. bitshares#9
0688b7e
oxarbitrage pushed a commit to oxarbitrage/bitshares-fc that referenced this pull request Mar 23, 2018
Refactor to use cmake build options bitshares#9
c1a0dca
oxarbitrage pushed a commit to oxarbitrage/bitshares-fc that referenced this pull request Mar 23, 2018
Actually log methods and params bitshares#9
7144cdc
oxarbitrage pushed a commit to oxarbitrage/bitshares-fc that referenced this pull request Mar 23, 2018
Merge pull request bitshares#11 from steemit/9-log-api-times
5cfcb5c 
Actually log methods and params bitshares#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abitmore @pmconrad @oxarbitrage