Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -std=c++14 flag from CMakeLists.txt #32

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Remove -std=c++14 flag from CMakeLists.txt #32

merged 1 commit into from
Mar 27, 2018

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Mar 25, 2018 •
edited
Loading

We aren't really using c++14. Remove the requirement so we can build in Ubuntu 14.04 with default shipped gcc 4.8.

@abitmore abitmore mentioned this pull request Mar 27, 2018
Open
jmjatlanta
jmjatlanta approved these changes Mar 27, 2018
View reviewed changes
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled fine with gcc 5.4.0 on Ubuntu 16.04 and MSVC14 on Windows 10.

@abitmore abitmore merged commit 4441e14 into master Mar 27, 2018
@abitmore abitmore deleted the abitmore-patch-1 branch March 28, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @jmjatlanta