Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class serialization #22

Merged
merged 3 commits into from
Mar 18, 2018
Merged

Fix class serialization #22

merged 3 commits into from
Mar 18, 2018

Conversation

abitmore
Copy link
Member

Deprecate default pack and unpack functions which was formerly implemented with I/O operators (<< and >>).

This will break serialization of graphene::chain::extension<> in bitshares-core.

Perhaps better to remove the functions directly, so errors will raise at compile time?

@pmconrad
Copy link

IMO compile-time errors are definitely preferrable.

@abitmore abitmore mentioned this pull request Mar 14, 2018
Merged
@abitmore abitmore merged commit efa4a50 into bitshares:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @pmconrad