Fix core #1935

[pmconrad]

Attempt to fix bitshares/bitshares-core#1935

[abitmore]

One minor issue, current release/develop branch of bitshares-core repository has FC at 91d8772, but current master branch of FC has new commits about OpenBSD support. Do we want to bump FC in bitshares-core to include the OpenBSD commits as well?

[pmconrad]

Hm. We have no clearly defined procedure for fc fixes during a release.
The point of working on the release branch is to uphold the feature freeze associated with entering release mode. Thus, after merging we should bump fc to 7b37cd6 instead of master.

[abitmore]

Yes, I think so as well. Perhaps create a 3.3 branch in this repository, so we can add new commits to it if needed.

By the way, 3.2.1 release's FC points to fix-api-close branch in this repository. The branch is configured as protected to avoid accidental removal until next consensus release.

[pmconrad]

By the way, 3.2.1 release's FC points to fix-api-close branch in this repository. The branch is configured as protected to avoid accidental removal until next consensus release.

Submodules never point to branch names but always to specific commits AFAIK. Removing the branch shouldn't hurt.

[abitmore]

Removing the branch shouldn't hurt.

... as long as the commit isn't removed by GC due to potential "unreachable" state. You're correct that submodule doesn't point to a branch, I wrote "head of xx branch" at first, but forgot why removed the words when reviewing / editing. :/