Fix websocket client crash on quit #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary differences between websocket_client_impl and websocket_tls_client_impl.
pmconrad
approved these changes
May 27, 2019
|
Will refactor the ws server classes in the same way in a new PR (will need to resolve conflicts due to #134). |
17 tasks
17 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a crash-on-quit issue, see bitshares/bitshares-core#1695 (comment).
By the way, refactored
websocket_client_implclass andwebsocket_tls_client_implclass, moved duplicate code to a template class.