Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cli_quitting to true in cli::cancel() #129

Merged
merged 2 commits into from
May 13, 2019
Merged

Set cli_quitting to true in cli::cancel() #129

merged 2 commits into from
May 13, 2019

Conversation

abitmore
Copy link
Member

For bitshares/bitshares-core#1690 / bitshares/bitshares-core#1695, to mitigate race condition.

Moved code blocks around for better readability. The root reason is the cli_quitting variable is declared too late in the file.

@abitmore abitmore mentioned this pull request May 12, 2019
Merged
@abitmore
Let rl_getc() always return EOF when quitting
30ea9b4 
even if got an EOL or CTRL+C or etc
pmconrad
pmconrad approved these changes May 13, 2019
View reviewed changes
Copy link

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Haven't tested.

@abitmore abitmore merged commit 7e612be into master May 13, 2019
@abitmore abitmore deleted the quit-cli branch May 13, 2019 13:08
@abitmore abitmore added this to the core-release-3.2.0 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
core-release-3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @pmconrad