-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1584 simplifications #120
1584 simplifications #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small items for Windows and Mac. The increase in tcp_socket.hpp line 54 is interesting. You may know more about it than I do. As I see there was a similar problem in file_mapping.hpp.
Another consideration: CMakeModules/FindBOOST.cmake is broken on macOS and Windows. Would you consider removing it as part of your cleanup? Things build fine without it on those platforms, and probably Linux as well (haven't tried yet).
I think the reason for the problems with |
Tried to remove FindBoost, but ran into a linker error concerning |
I guess my dream will have to wait, then. :-) Now compiles on macOS and Windows. I am now working on a more thorough review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job. Tested on Ubuntu 19.04 / Boost 1.67 / BitShares develop branch. Tests in FC and core/chain_test run with no errors detected. Code looks clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job. Tested on Ubuntu 19.04 / Boost 1.67 / BitShares develop branch. Tests in FC and core/chain_test run with no errors detected. Code looks clean.
Question for my own education: The uncommenting of deque pack and unpack... Everything compiles if this remained commented out. Would the raw pack/unpack have taken over? |
They were previously in |
1st round of simplifications. Removed lots of stuff. The result is still compatible with current core.
Sorry about the mess in the 1st commit. I had it separated into many nice and clean commits, then destroyed my
.git
folder. :-/ Note to self: never usefind | xargs sed -i
in top-level project dir.Highlights in 1st commit:
fc::any
withboost::any
fc::min
withstd::min
fc::move
withstd::move
fc::string
withstd::string
(core still usesfc::string
so can't remove the typedef yet)fc::aligned<>
withalignas
fc::remove_reference
withstd::remove_reference
fc_swap
withstd::swap
The last change is to remove the openssl-based ECC implementation, which is slow and disabled by default. See discussion in bitshares/bitshares-core#1584
More to follow, but that will require changes in core as well, so I wanted to get this in now.