Refactor cancel_all_subscriptions (Issue #762) #983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Need to merge bitshares/bitshares-fc#50 first. |
change project description doxygen
The peer is an attacker or buggy, which means the item_hashes_received is not correct. Move the check before updating items ids to save some time in this case.
Openssl 1.1 support
node.cpp: Check the attacker/buggy client before updating items ids
bump fc for openssl1.1
…core into jmj_issue_762
|
Sorry for the unrelated commits, but changes in fc and core required me to rebase, and evidently I goofed somewhere in the process. I'll create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #762.
There are no changes to the API or functionality of
cancel_all_subscriptions.There are no changes to the API or functionality of
set_subscribe_callback.set_subscribe_callback does not reset
_market_subscriptions, which does not seem correct to me, but I left the functionality alone. If a change in functionality is desired, it will further simplify the cancel function.