extend debug_dump checks

[oxarbitrage]

for issue #136

[pmconrad]

Question: does it make sense that this is called at the end of init_genesis?

• We're not going to change genesis anytime soon.
• Running that check only increases startup time.
• For the unit tests, database_fixture::verify_asset_supplies is much more relevant.
• The name is misleading, it doesn't actually dump anything.
• Logging an error is is not helpful because nobody really looks at the logs. I agree with the OP that this should be considered a fatal error.

Apparently it was intended that this function can be used in different places, e. g. at https://github.com/bitshares/bitshares-core/blob/master/libraries/chain/db_market.cpp#L47 . Adding genesis as a parameter would defeat that purpose.

[oxarbitrage]

@pmconrad i think you are right, was not seeing the full picture.

in this commit: a0f7560

• i removed the genesis parameter from the call.
• removed genesis balance checks.
• i decided to keep the vesting balance and settle checks.
• commented call in db_init.cpp
• marked as fatal with exit(0), not sure if it is the best.

[pmconrad]

Don't call exit(). Better throw. (And if you do call exit, use a non-zero exit value to indicate an error. But don't call it.)

[oxarbitrage]

changed it, thanks.

[pmconrad]

Uh, at least use FC_THROW with an explanatory message. Perhaps I should have been more explicit. :-)

[oxarbitrage]

sorry, changing now :)