Handle acc_trx_his_object in get_relevant_accounts #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dockercloud check is failing due to dockercloud messing up somehow |
abitmore
added
the
2a Discussion Needed
|
These history objects are static. It doesn't make sense to subscribe to them because they will not change anyway. I think this is the reason for the exclusion in database_api. That doesn't mean that they can't be of interest to other callback functions of course. |
pmconrad
suggested changes
Apr 20, 2018
libraries/chain/db_notify.cpp
Outdated
| case impl_account_transaction_history_object_type: | ||
| case impl_account_transaction_history_object_type: { | ||
| const auto& aobj = dynamic_cast<const account_transaction_history_object*>(obj); | ||
| assert( aobj != nullptr ); |
There was a problem hiding this comment.
Please use FC_ASSERT instead
pmconrad
approved these changes
Apr 21, 2018
abitmore
removed
the
2a Discussion Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, I'm not sure if it's skipped intentionally. See this code: