Move node and application implementations to header file #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
approved these changes
Apr 3, 2018
|
@pmconrad can you please take a look? |
pmconrad
approved these changes
Apr 9, 2018
There was a problem hiding this comment.
Good job.
General advice @ALL for the future: please structure your commits in a way that makes it easier to follow the changes. For example,
- use separate commits for whitespace-only changes
- use separate commits when extracting large chunks of code into separate files
- before pushing, use
rebase -ito squash minor fixes into the broken commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node and application implementations were embedded in their respective .cpp file. Under normal conditions, this is preferable in order to hide the actual implementation. But it makes testing very difficult.
Tests can now inherit from these implementations and twist them to their needs, with minimal changes to the class definition (i.e. mark a method virtual, change a member variable to protected instead of private) and hopefully no changes to the actual implementation within the .cpp file.
These commits change a large number of lines, but the actual logic changes are (hopefully) nil. Please carefully critique.
Also included is an adjustment to make the app_test tests pass, as well as share some code with the cli_test application (moved some common code to a header file).