Add broadcast_transaction method for broadcasting transaction signed by … #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secp256
changed the title
abitmore
requested changes
Feb 9, 2018
| @@ -507,6 +507,12 @@ class wallet_api | |||
| * @ingroup Transaction Builder API | |||
| */ | |||
| signed_transaction sign_builder_transaction(transaction_handle_type transaction_handle, bool broadcast = true); | |||
|
|
|||
| /** | |||
| * @ingroup broadcast signed transaction | |||
There was a problem hiding this comment.
Using @ingroup here is not correct, please fix.
abitmore
approved these changes
Feb 9, 2018
oxarbitrage
approved these changes
Feb 10, 2018
There was a problem hiding this comment.
looks good, maybe remove https://github.com/zhuliting/bitshares-core/blob/bf27fb801026c5f5fdb8c2517cab115367ba5db1/libraries/wallet/include/graphene/wallet/wallet.hpp#L671 if you can. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broadcast_transaction method for broadcasting transaction signed by cold wallet