Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution for issue #652 - Removed unused index by_feed_expiration #654

Merged

Conversation

jmjatlanta
Copy link
Contributor

The index 'by_feed_expiration' is unused. This change removes the index by removing the code.

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good John, compiles and synchronizing fine as well.
interesting to see that the struct by_id is not needed. maybe we can remove it from other places as well. what do you guys think ?

@abitmore
Copy link
Member

abitmore commented Feb 8, 2018

We want to remove the by_feed_expiration index because it will consume a little RAM and computing resources in production (need to insert/update when data changes). The by_id tag doesn't do any harm.

@abitmore abitmore added this to the Next Non-Consensus-Changing Release milestone Feb 8, 2018
@oxarbitrage oxarbitrage merged commit 97d86fe into bitshares:develop Feb 8, 2018
@jmjatlanta jmjatlanta deleted the Issue652_index_by_feed_expiration branch May 25, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants