Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: proposals should show the proposer/fee_paying_account #608

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

xeroc
Copy link
Member

@xeroc xeroc commented Jan 29, 2018

Pretty simple but sometimes useful feature, IMHO.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@oxarbitrage oxarbitrage self-requested a review January 29, 2018 15:17
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good:

alfredo@alfredo-Inspiron-5559 ~/CLionProjects/pull608/bitshares-core $ curl --silent -d '{"id":1,"method":"call","params":["database","get_objects",[["1.10.45"]]]}' http://127.0.0.1:8090/ws | jq
{
  "id": 1,
  "jsonrpc": "2.0",
  "result": [
    {
      "id": "1.10.45",
      "expiration_time": "2015-12-31T23:59:59",
      "review_period_time": "2015-12-31T22:59:59",
      "proposed_transaction": {
        "ref_block_num": 0,
        "ref_block_prefix": 0,
        "expiration": "2015-12-31T23:59:59",
        "operations": [
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "burn-100k-1",
              "url": "http://bitshares.org",
              "initializer": [
                2,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "burn-100k-2",
              "url": "http://bitshares.org",
              "initializer": [
                2,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "burn-100k-3",
              "url": "http://bitshares.org",
              "initializer": [
                2,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "burn-100k-4",
              "url": "http://bitshares.org",
              "initializer": [
                2,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "refund-100k-1",
              "url": "http://bitshares.org",
              "initializer": [
                0,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "refund-100k-2",
              "url": "http://bitshares.org",
              "initializer": [
                0,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "refund-100k-3",
              "url": "http://bitshares.org",
              "initializer": [
                0,
                {}
              ]
            }
          ],
          [
            34,
            {
              "fee": {
                "amount": 200000,
                "asset_id": "1.3.0"
              },
              "owner": "1.2.0",
              "work_begin_date": "2016-01-01T00:00:00",
              "work_end_date": "2016-12-31T23:59:59",
              "daily_pay": "10000000000",
              "name": "refund-100k-4",
              "url": "http://bitshares.org",
              "initializer": [
                0,
                {}
              ]
            }
          ]
        ],
        "extensions": []
      },
      "required_active_approvals": [
        "1.2.0"
      ],
      "available_active_approvals": [],
      "required_owner_approvals": [],
      "available_owner_approvals": [],
      "available_key_approvals": [],
      "proposer": "1.2.282"
    }
  ]
}
alfredo@alfredo-Inspiron-5559 ~/CLionProjects/pull608/bitshares-core $ 

@oxarbitrage oxarbitrage merged commit b2afc7a into develop Jan 29, 2018
@abitmore abitmore added this to the Next Non-Consensus-Changing Release milestone Jan 31, 2018
@abitmore abitmore deleted the proposals-show-proposer branch February 2, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants