Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buy and sell (with doubles) from CLI. #544 #595

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Remove buy and sell (with doubles) from CLI. #544 #595

merged 1 commit into from
Jan 23, 2018

Conversation

abitmore
Copy link
Member

PR for #544.

@abitmore abitmore mentioned this pull request Jan 23, 2018
Closed
oxarbitrage
oxarbitrage approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the commands are broken i am ok with removing them with this pull. i cant see any problem on doing this that is worst than having them without working properly.

still, maybe in the future we can add them as i think they are good to have.

pmconrad
pmconrad approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the API has many users, because anyone using it should have already run into problems with it. Therefore it's ok to remove IMO.

@abitmore abitmore merged commit 496ab0f into bitshares:develop Jan 23, 2018
@abitmore abitmore deleted the 544-remove-buy-sell-cmd branch June 28, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201802 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
3 participants
@abitmore @pmconrad @oxarbitrage