Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix withdrawal claim too early #386

Merged

Conversation

TheTaconator
Copy link
Contributor

This pull request is a modification of Request #23 that:

(a) has moved a class that was only used for unit tests into a unit test file, and
(b) is attempting to merge into the develop branch rather than the master branch

All tests within operation_tests2.cpp pass

Note: The integrator of this pull request should review the HARDFORK_23_TIME to see whether it should be modified.

@pmconrad pmconrad added this to the Hardfork - Bugs milestone Aug 31, 2017
@pmconrad pmconrad self-requested a review August 31, 2017 16:31
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok. Test cases are successful. Replay works.
Thanks!

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good @TheTaconator . approved from here.

@oxarbitrage oxarbitrage merged commit 2134eab into bitshares:develop Sep 6, 2017
@TheTaconator TheTaconator deleted the fix_withdrawal_claim_too_early branch September 8, 2017 13:56
@abitmore abitmore modified the milestones: Hardfork - Bugs , Hardfork - 201711 - BSIP 018 and etc Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants