Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #284 using API calls #321

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Jul 1, 2017

...as recommended by abit.

@pmconrad pmconrad changed the base branch from master to develop July 12, 2017 20:44
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. May need testing. @oxarbitrage can you help?

@oxarbitrage
Copy link
Member

definitively, will test today and send feedback!

@oxarbitrage
Copy link
Member

oxarbitrage commented Aug 9, 2017

i was able to reproduce the error of issue #284 from @Xeldal in a private testnet by setting up the nathan account exactly as he describes. this is by adding an additional key to owner and an additional key to active.

i was able to do this by putting the call update_all_auth from here: #270 into the test environment code.

after adding this additional keys i started a new wallet and imported nathan priv key and the private key for the active i added before to nathan.

following the setup described i don't have the priv key for the additional owner key so i don't import it in the new session. thereshold and weight remained always at 1.

in unpatched versions when trying to transfer error msg described by #284 is thrown and transfer can't be made.

in a patched version with this pull request transfer goes throw.

works good, i am merging the pull. good job @pmconrad

offtopic:
resumed work in #270 with the suggestions sent by @pc and @TheTaconator and @vikramrajkumar as it is a really needed function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants