-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data deletion in es_objects plugin, update program options #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
and remove the postfix increment operator
store-updates and no-delete for each applicable object
17 tasks
Kudos, SonarCloud Quality Gate passed! |
abitmore
changed the title
Fix data deletion in es_objects plugin
Fix data deletion in es_objects plugin, update program options
Dec 28, 2021
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2464.
Features:
es-objects-sync-db-on-startup
to copy all applicable objects from the object database (chain state) to ES on program startupes-objects-keep-only-current
option, add new optionses-objects-accounts-store-updates
, defaultfalse
es-objects-assets-store-updates
, defaultfalse
es-objects-asset-bitasset-store-updates
, defaultfalse
es-objects-balances-store-updates
, defaultfalse
es-objects-proposals-store-updates
, defaultfalse
es-objects-proposals-no-delete
, defaulttrue
es-objects-limit-orders-store-updates
, defaultfalse
es-objects-limit-orders-no-delete
, defaultfalse
es-objects-limit-orders
totrue
Done some code cleanups and refactory.
Tasks:
--es-objects-sync-db-on-startup
option{ ..., "errors":false, "items":[{"delete":{ ..., "result":"not_found", ..., "status":404}}, ... ]}
keep-only-current
option, add dedicatedstore-updates
andno-delete
options for each applicable object